Skip to content

Remove unused ANTHROPIC_BASE_URL secret input#5

Merged
xdanger merged 2 commits intomainfrom
xdanger-claude/nervous-ptolemy
Mar 29, 2026
Merged

Remove unused ANTHROPIC_BASE_URL secret input#5
xdanger merged 2 commits intomainfrom
xdanger-claude/nervous-ptolemy

Conversation

@xdanger
Copy link
Copy Markdown
Member

@xdanger xdanger commented Mar 29, 2026

Summary

  • Remove the unused ANTHROPIC_BASE_URL secret from workflow_call inputs — the step uses vars.ANTHROPIC_BASE_URL (a repo variable) instead, so the secret was never referenced

Test plan

  • Verify the workflow still triggers correctly on pull_request and workflow_call
  • Confirm ANTHROPIC_BASE_URL is still passed via vars.* at runtime

🤖 Generated with Claude Code

- 🔥 The `workflow_call` declared it as a secret, but the step uses `vars.ANTHROPIC_BASE_URL` (a repo variable) instead

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions github-actions bot requested a review from Copilot March 29, 2026 12:35
@xdanger xdanger review requested due to automatic review settings March 29, 2026 12:35
@xdanger xdanger self-assigned this Mar 29, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e33d7c3beb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

- 📝 Move `ANTHROPIC_BASE_URL` from Secrets table to a new Variables section
- 🔥 Remove commented-out secret line from usage example

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies the reusable Code Review GitHub Actions workflow by removing the unused ANTHROPIC_BASE_URL secret from workflow_call inputs, aligning the interface with current usage (vars.ANTHROPIC_BASE_URL).

Changes:

  • Remove ANTHROPIC_BASE_URL from on.workflow_call.secrets in the reusable workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@xdanger xdanger merged commit f6a9c53 into main Mar 29, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants